Revert "Integration test for Is_Zero (#494)"

This reverts commit b5dac4c.
NethermindEth · Jun 28, 2024 · 83ca35c · 83ca35c
1 parent b5dac4c
commit 83ca35c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 39 deletions.
diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -18,7 +18,7 @@ jobs:
           python-version: '3.9'
 
       - name: Install cairo-lang
-        run: pip install cairo-lang==0.13.1
+        run: pip install cairo-lang==0.11
 
       - name: Build
         run: make build

diff --git a/integration_tests/.env b/integration_tests/.env
@@ -1,2 +1,2 @@
 # Set to run some specific file tests (ex. fib.cairo,alloc.cairo)
-INTEGRATION_TESTS_FILTERS=is_zero.small.cairo
+INTEGRATION_TESTS_FILTERS=
diff --git a/integration_tests/cairo_zero_hint_tests/is_zero.small.cairo b/integration_tests/cairo_zero_hint_tests/is_zero.small.cairo
diff --git a/pkg/hintrunner/zero/hintcode.go b/pkg/hintrunner/zero/hintcode.go
@@ -94,7 +94,7 @@ ids.multiplicities = segments.gen_arg([len(positions_dict[k]) for k in output])`
 	ecDoubleAssignNewXV1Code string = "from starkware.cairo.common.cairo_secp.secp_utils import SECP_P, pack\n\nslope = pack(ids.slope, PRIME)\nx = pack(ids.point.x, PRIME)\ny = pack(ids.point.y, PRIME)\n\nvalue = new_x = (pow(slope, 2, SECP_P) - 2 * x) % SECP_P"
 	ecDoubleAssignNewYV1Code string = "value = new_y = (slope * (x - new_x) - y) % SECP_P"
 	ecMulInnerCode           string = "memory[ap] = (ids.scalar % PRIME) % 2"
-	isZeroNondetCode         string = "memory[ap] = to_felt_or_relocatable(x == 0)"
+	isZeroNondetCode         string = "x == 0"
 	isZeroPackCode           string = "from starkware.cairo.common.cairo_secp.secp_utils import SECP_P, pack\n\nx = pack(ids.x, PRIME) % SECP_P"
 	isZeroDivModCode         string = "from starkware.cairo.common.cairo_secp.secp_utils import SECP_P\nfrom starkware.python.math_utils import div_mod\n\nvalue = x_inv = div_mod(1, x, SECP_P)"
 

diff --git a/pkg/hintrunner/zero/zerohint_ec.go b/pkg/hintrunner/zero/zerohint_ec.go
@@ -736,10 +736,9 @@ func createEcMulInnerHinter(resolver hintReferenceResolver) (hinter.Hinter, erro
 // i.e, 1 if `x == 0`, 0 otherwise
 func newIsZeroNondetHint() hinter.Hinter {
 	return &GenericZeroHinter{
-		Name: "IsZeroNondet",
+		Name: "IsZeroConditional",
 		Op: func(vm *VM.VirtualMachine, ctx *hinter.HintRunnerContext) error {
-			//> python hint in cairo file: "x == 0"
-			//> compiled file hint: "memory[ap] = to_felt_or_relocatable(x == 0)"
+			//> x == 0
 
 			x, err := ctx.ScopeManager.GetVariableValueAsBigInt("x")
 			if err != nil {
@@ -776,7 +775,6 @@ func newIsZeroPackHint(x hinter.ResOperander) hinter.Hinter {
 		Name: "IsZeroPack",
 		Op: func(vm *VM.VirtualMachine, ctx *hinter.HintRunnerContext) error {
 			//> from starkware.cairo.common.cairo_secp.secp_utils import SECP_P, pack
-
 			//> x = pack(ids.x, PRIME) % SECP_P
 
 			xAddr, err := x.GetAddress(vm)
@@ -831,7 +829,6 @@ func newIsZeroDivModHint() hinter.Hinter {
 		Op: func(vm *VM.VirtualMachine, ctx *hinter.HintRunnerContext) error {
 			//> from starkware.cairo.common.cairo_secp.secp_utils import SECP_P
 			//> from starkware.python.math_utils import div_mod
-
 			//> value = x_inv = div_mod(1, x, SECP_P)
 
 			secPBig, ok := secp_utils.GetSecPBig()