Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test correct calculation of the res auxiliar value #56

Closed
Tracked by #19
rodrigo-pino opened this issue Sep 20, 2023 · 1 comment
Closed
Tracked by #19

Test correct calculation of the res auxiliar value #56

rodrigo-pino opened this issue Sep 20, 2023 · 1 comment
Assignees
Labels

Comments

@rodrigo-pino
Copy link
Contributor

No description provided.

@rodrigo-pino rodrigo-pino changed the title Test correct calculation of the res auxiliar value when using both addition, multiplication and nil respectively. Also a test where it should error as well. Test correct calculation of the res auxiliar value Sep 20, 2023
jkktom added a commit that referenced this issue Oct 2, 2023
rodrigo-pino added a commit that referenced this issue Oct 2, 2023
* edited comments todo list

* verify Compute Result Addition via more test results. Minor update on add function on memory_value.go

* Verify Test for ComputeRes Addition

* improve better format for test function

* separate each cases to have own functions

* add Mulitple operand test cases and also Unconstrained, Op1

* wip memory addition

* Fixes add function with felt-to-address addition

* added UpdatePc tests  (#61)

* added UpdatePc tests and fixed a bug in UpdatePc

* Fixed accessing field value without Read()

* fixed failing tests

* small refactor for TestUpdatePcJump

* Chore: Readme hotfix

* separate each cases to have own functions

* Fix as per comments of prev. PR. Fixes issue #56 adding test cases and code change

* integration test done

* minor change on comments

* Remove factorial_compiled.json

* Fix add implementation

---------

Co-authored-by: M. Mahdi Khosravi <mmk1776@gmail.com>
Co-authored-by: Rodrigo <rodrodpino@gmail.com>
@jkktom
Copy link
Contributor

jkktom commented Oct 9, 2023

Fixed in #60

@jkktom jkktom closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants