Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement cairo0 hints needed for assert_le_felt #203

Merged
merged 1 commit into from
Feb 14, 2024
Merged

implement cairo0 hints needed for assert_le_felt #203

merged 1 commit into from
Feb 14, 2024

Conversation

quasilyte
Copy link
Contributor

In turn, assert_le_felt is needed for some other functions that use cairo0 hints, like is_nn.

@quasilyte
Copy link
Contributor Author

The tests are probably going to fail now, see #202
Perhaps we need to use some other testing strategy for the cases like this.
Or maybe the test file's code itself should be fixed.

cicr99
cicr99 reviewed Feb 14, 2024
View reviewed changes
pkg/hintrunner/zero/hint_reference_resolver.go Show resolved Hide resolved
pkg/hintrunner/zero/hintcode.go Outdated Show resolved Hide resolved
integration_tests/cairo_files/math.cairo Outdated Show resolved Hide resolved
@quasilyte
implement cairo0 hints needed for assert_le_felt
9497dd3 
In turn, `assert_le_felt` is needed for some other
functions that use cairo0 hints, like `is_nn`.
@cicr99 cicr99 merged commit d9abd6d into main Feb 14, 2024
4 checks passed
@cicr99 cicr99 deleted the quasilyte_assert_felt_le branch February 14, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicr99 cicr99 cicr99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quasilyte @cicr99