Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use idiomatic error messages for hint errors #38

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Use idiomatic error messages for hint errors #38

merged 1 commit into from
Sep 7, 2023

Conversation

joshklop
Copy link
Contributor

@joshklop joshklop commented Sep 5, 2023

No description provided.

@joshklop joshklop marked this pull request as draft September 5, 2023 02:50
@joshklop joshklop force-pushed the joshklop/errors branch 2 times, most recently from 6c70b55 to 50d58d5 Compare September 5, 2023 21:50
@joshklop joshklop marked this pull request as ready for review September 5, 2023 21:51
rodrigo-pino
rodrigo-pino approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion with Josh about the existence of custom error types, we've decided against them for the moment in order to minimize project complexity without sacrificing error description

@joshklop joshklop merged commit fb1d625 into main Sep 7, 2023
3 checks passed
@joshklop joshklop deleted the joshklop/errors branch September 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-pino rodrigo-pino rodrigo-pino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshklop @rodrigo-pino