Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Scope Usage Consistence in all Tests #387

Merged

Conversation

TAdev0
Copy link
Member

@TAdev0 TAdev0 commented May 3, 2024

@cicr99 As discussed today, here is the PR following the merge of :

#382 (comment)

This PR makes sure there is no extra scope in any test

Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cicr99 cicr99 linked an issue May 7, 2024 that may be closed by this pull request
@TAdev0 TAdev0 requested a review from cicr99 May 7, 2024 09:34
@cicr99 cicr99 merged commit d8467f6 into NethermindEth:main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize scopes when creating hint context
3 participants