-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Run separate cairo integration test files as a separate Go test #392
feat: Run separate cairo integration test files as a separate Go test #392
Conversation
@rodrigo-pino @quasilyte @cicr99 Please help me to review. Thank you very much. |
Hey, I left a comment on the issue. Can you please check it? |
@MaksymMalicki I have made this improvement. Thanks for your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I hadn't thought about having multiple filters. I think is a nice addition. Just leaving some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great as it is. If you want to improve the PR a little more there are two things we can do:
- Given the current code it might be nice to refactor into an object
Filter
which will have two functions:new
where it will initialize the filterfilter
where it filters the code
- Add a section to the readme explaining how to use filters
You can do one or two, or none. Just let me know. In case of none, I'll approve immediately.
@rodrigo-pino I have refactored into an object Filter. Thank you very much for your suggestion and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
@xiaolou86 there is a linting error: Error: Error return value of Can you resolve this? |
@TAdev0 Done. Thank you very much. |
Resolves #201
First checking if the environment variable
INTEGRATION_TESTS_FILTERS
is set in the console.And if not, then load it from the .env file.