Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cairo Zero Parser #40

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Cairo Zero Parser #40

merged 7 commits into from
Sep 13, 2023

Conversation

krafugo
Copy link
Contributor

@krafugo krafugo commented Sep 5, 2023 •
edited
Loading

Description

  • Add Cairo Zero structs
  • Add test cases to check marshaling

Comment

  • Field debug-info is still needed to be completed

rodrigo-pino
rodrigo-pino reviewed Sep 10, 2023
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some comments here and there

pkg/parsers/zero/zero_test.go Outdated Show resolved Hide resolved
pkg/parsers/zero/zero.go Outdated Show resolved Hide resolved
rodrigo-pino
rodrigo-pino approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure matches the output of a Cairo Zero compiled program and there are unit tests for each field.

@rodrigo-pino rodrigo-pino merged commit b8004e5 into main Sep 13, 2023
3 checks passed
@rodrigo-pino rodrigo-pino deleted the dev/marshal-json-output branch September 13, 2023 21:32
@rodrigo-pino rodrigo-pino mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-pino rodrigo-pino rodrigo-pino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krafugo @rodrigo-pino