Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DictUpdate hint #408

Merged
merged 61 commits into from
Jun 12, 2024
Merged

Implement DictUpdate hint #408

merged 61 commits into from
Jun 12, 2024

Conversation

har777
Copy link
Contributor

@har777 har777 commented May 13, 2024

Implements #291

@har777 har777 marked this pull request as ready for review May 14, 2024 06:08
@har777 har777 requested a review from TAdev0 May 14, 2024 06:10
pkg/hintrunner/zero/zerohint_dictionaries.go Outdated Show resolved Hide resolved
* Add initial skeleton

* Implement DictNew hint

* Move dictionary manager to scope

* Fix lint errir

* Add GetDictionaryManager util

* Change return signature

* Fix pointer issue

* Clean up some tests

* Add comment

* Reuse context dict manager

* Fix some comments

* Add better comments

* Fix bad comment ident
Base automatically changed from dictwrite_hint to main June 9, 2024 17:13
Copy link
Contributor

@cicr99 cicr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a minor question this PR looks good to me

pkg/hintrunner/zero/zerohint_dictionaries.go Outdated Show resolved Hide resolved
pkg/hintrunner/zero/zerohint_dictionaries.go Outdated Show resolved Hide resolved
@har777 har777 merged commit f8f8c77 into main Jun 12, 2024
4 checks passed
@har777 har777 deleted the dictupdate_hint branch June 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DictUpdate
3 participants