Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SquashDict hint #412

Merged
merged 19 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions integration_tests/cairo_files/squash_dict.small.cairo
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
%builtins range_check

from starkware.cairo.common.squash_dict import squash_dict
from starkware.cairo.common.alloc import alloc
from starkware.cairo.common.dict_access import DictAccess

func main{range_check_ptr}() -> () {
alloc_locals;
let (dict_start: DictAccess*) = alloc();
assert dict_start[0] = DictAccess(key=0, prev_value=100, new_value=100);
assert dict_start[1] = DictAccess(key=1, prev_value=50, new_value=50);
assert dict_start[2] = DictAccess(key=0, prev_value=100, new_value=200);
assert dict_start[3] = DictAccess(key=1, prev_value=50, new_value=100);
assert dict_start[4] = DictAccess(key=0, prev_value=200, new_value=300);
assert dict_start[5] = DictAccess(key=1, prev_value=100, new_value=150);

let dict_end = dict_start + 6 * DictAccess.SIZE;
// (dict_start, dict_end) now represents the dictionary
// {0: 100, 1: 50, 0: 200, 1: 100, 0: 300, 1: 150}.

// Squash the dictionary from an array of 6 DictAccess structs
// to an array of 2, with a single DictAccess entry per key.
let (local squashed_dict_start: DictAccess*) = alloc();
let (squashed_dict_end) = squash_dict{range_check_ptr=range_check_ptr}(
dict_start, dict_end, squashed_dict_start
);

// Check the values of the squashed_dict
// should be: {0: (100, 300), 1: (50, 150)}
assert squashed_dict_start[0] = DictAccess(key=0, prev_value=100, new_value=300);
assert squashed_dict_start[1] = DictAccess(key=1, prev_value=50, new_value=150);
return ();
}
1 change: 1 addition & 0 deletions pkg/hintrunner/zero/hintcode.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ const (
dictReadCode string = "dict_tracker = __dict_manager.get_tracker(ids.dict_ptr)\ndict_tracker.current_ptr += ids.DictAccess.SIZE\nids.value = dict_tracker.data[ids.key]"
dictWriteCode string = "dict_tracker = __dict_manager.get_tracker(ids.dict_ptr)\ndict_tracker.current_ptr += ids.DictAccess.SIZE\nids.dict_ptr.prev_value = dict_tracker.data[ids.key]\ndict_tracker.data[ids.key] = ids.new_value"
dictUpdateCode string = "# Verify dict pointer and prev value.\ndict_tracker = __dict_manager.get_tracker(ids.dict_ptr)\ncurrent_value = dict_tracker.data[ids.key]\nassert current_value == ids.prev_value, \\\n f'Wrong previous value in dict. Got {ids.prev_value}, expected {current_value}.'\n\n# Update value.\ndict_tracker.data[ids.key] = ids.new_value\ndict_tracker.current_ptr += ids.DictAccess.SIZE"
squashDictCode string = "dict_access_size = ids.DictAccess.SIZE\naddress = ids.dict_accesses.address_\nassert ids.ptr_diff % dict_access_size == 0, \\\n 'Accesses array size must be divisible by DictAccess.SIZE'\nn_accesses = ids.n_accesses\nif '__squash_dict_max_size' in globals():\n assert n_accesses <= __squash_dict_max_size, \\\n f'squash_dict() can only be used with n_accesses<={__squash_dict_max_size}. ' \\\n f'Got: n_accesses={n_accesses}.'\n# A map from key to the list of indices accessing it.\naccess_indices = {}\nfor i in range(n_accesses):\n key = memory[address + dict_access_size * i]\n access_indices.setdefault(key, []).append(i)\n# Descending list of keys.\nkeys = sorted(access_indices.keys(), reverse=True)\n# Are the keys used bigger than range_check bound.\nids.big_keys = 1 if keys[0] >= range_check_builtin.bound else 0\nids.first_key = key = keys.pop()"
squashDictInnerAssertLenKeys string = "assert len(keys) == 0"
squashDictInnerContinueLoop string = "ids.loop_temps.should_continue = 1 if current_access_indices else 0"
squashDictInnerFirstIteration string = "current_access_indices = sorted(access_indices[key])[::-1]\ncurrent_access_index = current_access_indices.pop()\nmemory[ids.range_check_ptr] = current_access_index"
Expand Down
2 changes: 2 additions & 0 deletions pkg/hintrunner/zero/zerohint.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ func GetHintFromCode(program *zero.ZeroProgram, rawHint zero.Hint, hintPC uint64
return createDictWriteHinter(resolver)
case dictUpdateCode:
return createDictUpdateHinter(resolver)
case squashDictCode:
return createSquashDictHinter(resolver)
case squashDictInnerAssertLenKeys:
return createSquashDictInnerAssertLenKeysHinter()
case squashDictInnerContinueLoop:
Expand Down
152 changes: 152 additions & 0 deletions pkg/hintrunner/zero/zerohint_dictionaries.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/NethermindEth/cairo-vm-go/pkg/vm/memory"
"github.com/consensys/gnark-crypto/ecc/stark-curve/fp"
f "github.com/consensys/gnark-crypto/ecc/stark-curve/fp"
"golang.org/x/exp/maps"
)

// struct DictAccess {
Expand Down Expand Up @@ -367,6 +368,157 @@ func createDictUpdateHinter(resolver hintReferenceResolver) (hinter.Hinter, erro
return newDictUpdateHint(dictPtr, key, newValue, prevValue), nil
}

func newSquashDictHint(dictAccesses, ptrDiff, nAccesses, bigKeys, firstKey hinter.ResOperander) hinter.Hinter {
har777 marked this conversation as resolved.
Show resolved Hide resolved
return &GenericZeroHinter{
Name: "SquashDict",
Op: func(vm *VM.VirtualMachine, ctx *hinter.HintRunnerContext) error {
//> dict_access_size = ids.DictAccess.SIZE
//> address = ids.dict_accesses.address_
//> assert ids.ptr_diff % dict_access_size == 0, \
//> 'Accesses array size must be divisible by DictAccess.SIZE'
//> n_accesses = ids.n_accesses
//> if '__squash_dict_max_size' in globals():
//> assert n_accesses <= __squash_dict_max_size, \
//> f'squash_dict() can only be used with n_accesses<={__squash_dict_max_size}. ' \
//> f'Got: n_accesses={n_accesses}.'
//> # A map from key to the list of indices accessing it.
//> access_indices = {}
//> for i in range(n_accesses):
//> key = memory[address + dict_access_size * i]
//> access_indices.setdefault(key, []).append(i)
//> # Descending list of keys.
//> keys = sorted(access_indices.keys(), reverse=True)
//> # Are the keys used bigger than range_check bound.
//> ids.big_keys = 1 if keys[0] >= range_check_builtin.bound else 0
//> ids.first_key = key = keys.pop()

//> address = ids.dict_accesses.address_
address, err := dictAccesses.GetAddress(vm)
if err != nil {
return err
}

//> assert ids.ptr_diff % dict_access_size == 0, \
//> 'Accesses array size must be divisible by DictAccess.SIZE'
ptrDiffValue, err := hinter.ResolveAsUint64(vm, ptrDiff)
if err != nil {
return err
}
if ptrDiffValue%DictAccessSize != 0 {
return fmt.Errorf("Accesses array size must be divisible by DictAccess.SIZE")
}

//> n_accesses = ids.n_accesses
nAccessesValue, err := hinter.ResolveAsUint64(vm, nAccesses)
if err != nil {
return err
}

//> if '__squash_dict_max_size' in globals():
//> assert n_accesses <= __squash_dict_max_size, \
//> f'squash_dict() can only be used with n_accesses<={__squash_dict_max_size}. ' \
//> f'Got: n_accesses={n_accesses}.'
// __squash_dict_max_size is always in scope and has a value of 2**20,
squashDictMaxSize := uint64(1048576)
if nAccessesValue > squashDictMaxSize {
return fmt.Errorf("squash_dict() can only be used with n_accesses<={%d}. Got: n_accesses={%d}.", squashDictMaxSize, nAccessesValue)
}

//> # A map from key to the list of indices accessing it.
//> access_indices = {}
//> for i in range(n_accesses):
//> key = memory[address + dict_access_size * i]
//> access_indices.setdefault(key, []).append(i)
accessIndices := make(map[f.Element][]uint64)
for i := uint64(0); i < nAccessesValue; i++ {
memoryAddress, err := address.AddOffset(int16(DictAccessSize * i))
if err != nil {
return err
}
key, err := vm.Memory.ReadFromAddressAsElement(&memoryAddress)
if err != nil {
return err
}
accessIndices[key] = append(accessIndices[key], i)
}

//> # Descending list of keys.
//> keys = sorted(access_indices.keys(), reverse=True)
keys := maps.Keys(accessIndices)
if len(keys) == 0 {
return fmt.Errorf("empty keys array")
}
sort.Slice(keys, func(i, j int) bool {
return keys[i].Cmp(&keys[j]) > 0
})

//> ids.big_keys = 1 if keys[0] >= range_check_builtin.bound else 0
bigKeysAddr, err := bigKeys.GetAddress(vm)
if err != nil {
return err
}
var bigKeysMv memory.MemoryValue
if utils.FeltIsPositive(&keys[0]) {
bigKeysMv = memory.MemoryValueFromFieldElement(&utils.FeltZero)
} else {
bigKeysMv = memory.MemoryValueFromFieldElement(&utils.FeltOne)
}
err = vm.Memory.WriteToAddress(&bigKeysAddr, &bigKeysMv)
if err != nil {
return err
}

//> ids.first_key = key = keys.pop()
firstKeyAddr, err := firstKey.GetAddress(vm)
if err != nil {
return err
}
firstKeyValue := keys[len(keys)-1]
har777 marked this conversation as resolved.
Show resolved Hide resolved
firstKeyMv := memory.MemoryValueFromFieldElement(&firstKeyValue)
keys = keys[:len(keys)-1]
err = vm.Memory.WriteToAddress(&firstKeyAddr, &firstKeyMv)
if err != nil {
return err
}

err = ctx.ScopeManager.AssignVariable("access_indices", accessIndices)
if err != nil {
return err
}
err = ctx.ScopeManager.AssignVariable("keys", keys)
if err != nil {
return err
}
return ctx.ScopeManager.AssignVariable("key", firstKeyValue)
},
}
}

func createSquashDictHinter(resolver hintReferenceResolver) (hinter.Hinter, error) {
dictAccesses, err := resolver.GetResOperander("dict_accesses")
if err != nil {
return nil, err
}
ptrDiff, err := resolver.GetResOperander("ptr_diff")
if err != nil {
return nil, err
}
nAccesses, err := resolver.GetResOperander("n_accesses")
if err != nil {
return nil, err
}
bigKeys, err := resolver.GetResOperander("big_keys")
if err != nil {
return nil, err
}
firstKey, err := resolver.GetResOperander("first_key")
if err != nil {
return nil, err
}

return newSquashDictHint(dictAccesses, ptrDiff, nAccesses, bigKeys, firstKey), nil
}

// SquashDictInnerAssertLenKeys hint asserts that the length
// of the `keys` descending list is zero during the squashing process
//
Expand Down
Loading
Loading