Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize segments + layout flags (plain, small, starknet_with_keccak) #432

Merged
merged 41 commits into from
Jun 21, 2024
Merged

Finalize segments + layout flags (plain, small, starknet_with_keccak) #432

merged 41 commits into from
Jun 21, 2024

Conversation

MaksymMalicki
Copy link
Contributor

No description provided.

@MaksymMalicki MaksymMalicki marked this pull request as draft May 27, 2024 11:26
@MaksymMalicki MaksymMalicki self-assigned this Jun 1, 2024
@MaksymMalicki
Layout flag with layouts: plain, small, all_cairo (#435)
928766f 
* Create layout flag with layouts plain and small

* Fix error handling

* Fix error handling

* Add layout flag to Nethermind vm in the integration tests

* Fix unit tests

* Fix builtins integration tests, add layouts to builtins tests, remove failing "slices" package
@MaksymMalicki
Merge branch 'main' into Finalize-segments
7e00b05
@MaksymMalicki MaksymMalicki marked this pull request as ready for review June 3, 2024 10:08
@MaksymMalicki MaksymMalicki changed the title Finalize segments Finalize segments + layout flags (plain, small, all_cairo) Jun 3, 2024
har777
har777 reviewed Jun 3, 2024
View reviewed changes
cmd/cli/main.go Show resolved Hide resolved
@MaksymMalicki MaksymMalicki changed the title Finalize segments + layout flags (plain, small, all_cairo) Finalize segments + layout flags (plain, small, starknet_with_keccak) Jun 12, 2024
@MaksymMalicki MaksymMalicki linked an issue Jun 13, 2024 that may be closed by this pull request
Differences in decoded memory traces in the integration tests #422
Closed
TAdev0
TAdev0 reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaksymMalicki just finished the review, left a bunch of comments!

cmd/cli/main.go Show resolved Hide resolved
integration_tests/cairozero_test.go Outdated Show resolved Hide resolved
pkg/runners/zero/zero.go Outdated Show resolved Hide resolved
pkg/runners/zero/zero.go Show resolved Hide resolved
pkg/runners/zero/zero.go Show resolved Hide resolved
pkg/vm/builtins/layouts.go Outdated Show resolved Hide resolved
pkg/vm/builtins/range_check.go Show resolved Hide resolved
pkg/vm/builtins/range_check.go Show resolved Hide resolved
pkg/vm/vm.go Show resolved Hide resolved
pkg/vm/vm.go Show resolved Hide resolved
TAdev0
TAdev0 reviewed Jun 17, 2024
View reviewed changes
pkg/vm/vm.go Show resolved Hide resolved
cicr99
cicr99 reviewed Jun 19, 2024
View reviewed changes
pkg/vm/builtins/layouts.go Outdated Show resolved Hide resolved
pkg/vm/builtins/layouts.go Show resolved Hide resolved
pkg/vm/builtins/keccak.go Outdated Show resolved Hide resolved
pkg/vm/builtins/poseidon.go Outdated Show resolved Hide resolved
pkg/vm/builtins/poseidon.go Outdated Show resolved Hide resolved
pkg/runners/zero/zero.go Outdated Show resolved Hide resolved
pkg/runners/zero/zero.go Outdated Show resolved Hide resolved
pkg/runners/zero/zero.go Show resolved Hide resolved
pkg/runners/zero/zero.go Outdated Show resolved Hide resolved
pkg/runners/zero/zero.go Outdated Show resolved Hide resolved
@cicr99
Copy link
Contributor

cicr99 commented Jun 21, 2024 •
edited

I'm resolving the conversations regarding adding comments to the code. Those can be added in a separate PR

@cicr99 cicr99 merged commit c9d6cf7 into main Jun 21, 2024
4 checks passed
@cicr99 cicr99 deleted the Finalize-segments branch June 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@har777 har777 har777 left review comments

@TAdev0 TAdev0 TAdev0 approved these changes

@cicr99 cicr99 cicr99 approved these changes

@rodrigo-pino rodrigo-pino Awaiting requested review from rodrigo-pino

Assignees

@MaksymMalicki MaksymMalicki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differences in decoded memory traces in the integration tests
4 participants
@MaksymMalicki @cicr99 @har777 @TAdev0