Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify error handling in memory package #47

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

joshklop
Copy link
Contributor

@joshklop joshklop commented Sep 12, 2023

Reading through the codebase, refactoring the error messages as I go, hopefully improving consistency. Feel free to close the PR if the changes aren't what you're looking for.

Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this. I appreciate it very much!

pkg/vm/memory/memory.go Outdated Show resolved Hide resolved
pkg/vm/memory/memory_value.go Outdated Show resolved Hide resolved
@joshklop joshklop merged commit 1f15c48 into main Sep 12, 2023
3 checks passed
@joshklop joshklop deleted the joshklop/errors branch September 12, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants