Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT : Benchmark for integration tests #477

Merged
merged 17 commits into from
Jun 28, 2024

Conversation

Sh0g0-1758
Copy link
Contributor

This PR aims to add a Benchmark for Integration tests.

integration_tests/cairozero_test.go Outdated Show resolved Hide resolved
@TAdev0
Copy link
Member

TAdev0 commented Jun 22, 2024

looks good overall!
that way we ll have benchmarks for all cairo zero hints, and any cairo program we want

@TAdev0
Copy link
Member

TAdev0 commented Jun 22, 2024

@Sh0g0-1758 i just worked locally on a branch to run the rust VM as well in integration tests, as it is the one currently in production it might make sense to add it. Just wondering how to deal with workflow github action and running the rust vm

if we add the rust vm then we'll need to modify this as well to benchmark 3 runs

@Sh0g0-1758 Sh0g0-1758 requested a review from TAdev0 June 25, 2024 11:34
@TAdev0 TAdev0 merged commit 6d939e4 into NethermindEth:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants