NondetElementsOverTwo + NondetElementsOverTen( poseidon builtin related hints)
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh0g0-1758
reviewed
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i put them in Others, no better place
Closes #491
Closes #492
ok so , hintcodes are a bit different than the python hint we see in Cairo files.
See the compiled json files which shows the real hintcode we need to detect.
Current implementation works, our VM holds all assertions regarding outputs in the Cairo files test that does various types of Poseidon hash that involve the hint.
Integration tests dont work yet, the memory trace differs a bit at the end, need to fix this in another PR