feat: use GetVariableAs
generic method
#523
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #448
Resolves #347
@cicr99 @har777 @rodrigo-pino here is a PR for the Scope optimization issue. We ended up saying using a struct for scope values is not a good idea because the struct would contain too many fields.
An external contributor finally proposed to simply refactor all the
GetVariableAs...
method using a generic methodGetVariableAs
.I replaced all occurences in the whole codebase.
Did some benchmark to test the generic vs specific function for Big.int :
cost of using generics is really really negligible, while it reduces the codebase and makes it cleaner.
What do you think?
If we want to optimize the VM the most, i guess we should leave it as it is now, or just refactor a bit to make it more consistent (use a
GetVariableValueAs...
helper everywhere its needed, or nowhere, not just sometimes)