Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add extra tests for getCellDst using negative offsets #55

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

mmk-1
Copy link
Contributor

@mmk-1 mmk-1 commented Sep 20, 2023

Added two unit tests with negative offsets. One using AP & one using FP

Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@rodrigo-pino
Copy link
Contributor

Fixes #51

@rodrigo-pino rodrigo-pino changed the title added getCellDst test with negative offset Test: Add extra tests for getCellDst using negative offsets Sep 20, 2023
@rodrigo-pino rodrigo-pino merged commit 70dca16 into NethermindEth:main Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants