Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Normalizeaddress hint #588

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

har777
Copy link
Contributor

@har777 har777 commented Jul 22, 2024

Fix #568

@MaksymMalicki
Copy link
Contributor

The code looks good. Do you know why the hint code is not detected? If it is just simple typo to fix, the I'm giving approve

@har777
Copy link
Contributor Author

har777 commented Jul 23, 2024

The code looks good. Do you know why the hint code is not detected? If it is just simple typo to fix, the I'm giving approve

Ah that integration test needs another hint assigned to someone else. I'll move it to the in_progress folder.

Copy link
Member

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments but lgtm

pkg/hintrunner/zero/zerohint_others.go Show resolved Hide resolved
pkg/hintrunner/zero/zerohint_others_test.go Show resolved Hide resolved
pkg/hintrunner/zero/zerohint_others_test.go Show resolved Hide resolved
@TAdev0 TAdev0 merged commit bb072aa into main Jul 24, 2024
4 checks passed
@TAdev0 TAdev0 deleted the normalizeaddress_and_split128_hint branch July 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NormalizeAddress hint
3 participants