[#530] Added BigIntPackDivmod and BigIntSafeDiv hints #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAdev0
reviewed
Jul 27, 2024
There was a problem hiding this comment.
hi @adrianvrj,
could you copy paste this file:
in cairo_zero_hint_tests folder ? so that we make sure our vm produces the same trace and memory as the python one when we run a cairo file that uses your 2 hints.
Also could you add units tests for your hint? You can take inspiration with other hints
TAdev0
requested changes
Jul 27, 2024
TAdev0
requested changes
Jul 29, 2024
TAdev0
requested changes
Jul 29, 2024
TAdev0
reviewed
Jul 29, 2024
TAdev0
reviewed
Jul 30, 2024
TAdev0
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #530