Implement INumber interface
#38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flcl42
reviewed
Jan 15, 2024
| @@ -1650,6 +1654,16 @@ public static void Xor(in UInt256 a, in UInt256 b, out UInt256 res) | |||
| ? throw new OverflowException("Cannot convert UInt256 value to ulong.") | |||
| : a.u0; | |||
|
|
|||
| public static explicit operator Int128(in UInt256 a) => | |||
| a.u2 > 0 || a.u3 > 0 | |||
There was a problem hiding this comment.
Could you also confirm a.u1's last bit does not overflow sign?
| public static bool operator >=(UInt128 a, in UInt256 b) => !LessThan(a, in b); | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| private static bool LessThan(in UInt256 a, int b) => b >= 0 && a.u3 == 0 && a.u2 == 0 && a.u1 == 0 && a.u0 < (ulong)b; |
There was a problem hiding this comment.
if b==0 it seems to be false, so can be just b>0 I guess
| private static bool LessThan(in UInt256 a, int b) => b >= 0 && a.u3 == 0 && a.u2 == 0 && a.u1 == 0 && a.u0 < (ulong)b; | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| private static bool LessThan(int a, in UInt256 b) => b.u3 != 0 || b.u2 != 0 || b.u1 != 0 || (ulong)a < b.u0; |
flcl42
reviewed
Jan 15, 2024
| private static bool LessThan(int a, in UInt256 b) => b.u3 != 0 || b.u2 != 0 || b.u1 != 0 || (ulong)a < b.u0; | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| private static bool LessThan(in UInt256 a, uint b) => b >= 0 && a.u3 == 0 && a.u2 == 0 && a.u1 == 0 && a.u0 < b; |
|
Needs tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INumberinterface forInt256andUInt256typesInt128andUInt128support