Add plugin-specific setup sub-directory #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the only missing change is docs-related. Going to do that soon, but opening for reviews already |
emlautarom1
approved these changes
May 24, 2024
Comment on lines
+14
to
+15
| ecdsa_private_key_store_path: /near-sffl/config/keys/ecdsa.json | ||
| bls_private_key_store_path: /near-sffl/config/keys/bls.json |
There was a problem hiding this comment.
Not sure about this one, but shouldn't these paths be relative (./) rather than absolute (/)?
There was a problem hiding this comment.
Oh, these paths are from the container's point of view - so considering the shared plugin setup dir is mapped to /near-sffl, then those can be absolute like that
taco-paco
approved these changes
May 28, 2024
| # manually register the operator - not recommended | ||
| register_operator_on_startup: true | ||
| # manually register the operator. | ||
| register_operator_on_startup: false |
There was a problem hiding this comment.
Is that parameter planned to be used - ever to be true? It is quite an implicit one. Would be nice to get rid of it.
There was a problem hiding this comment.
I'd like to keep it, as it's convenient for a user that might want to use it and also for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not that nice having the plugin together with the operator
setup. The most notable situation is if an operator doesn't want to use theRegisterOnStartupsetting to preserve their private key. In this case, it's not practical to change the config or have two copies of the repo.This PR adds its own
setup/sub-directory to the operator plugin, with a separate config file,.envand so on.