Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit size of TransactionMessage by data size instead of tx count #4917

Closed
marcindsobczak opened this issue Nov 17, 2022 · 0 comments · Fixed by #5135
Closed

Limit size of TransactionMessage by data size instead of tx count #4917

marcindsobczak opened this issue Nov 17, 2022 · 0 comments · Fixed by #5135
Assignees
@marcindsobczak
Labels
eip-4844 network refactoring

Comments

@marcindsobczak
Copy link
Contributor

EIP-4844 introduces a new transaction type for blob transactions. These blob transactions are large. Right now we are limiting our TransactionMessage to 256 txs (https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/SyncPeerProtocolHandlerBase.cs#L200) which can be too much after EIP-4844.
We already introduced storing of tx sizes (#4866) so now we can limit message size by data size instead of tx count - in the same way as Geth do it:
https://github.com/ethereum/go-ethereum/blob/master/eth/protocols/eth/broadcast.go#L29
https://github.com/ethereum/go-ethereum/blob/master/eth/protocols/eth/broadcast.go#L82-L86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcindsobczak marcindsobczak

Labels
eip-4844 network refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor TxBroadcaster to limit messages by size NethermindEth/nethermind
1 participant
@marcindsobczak