Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter #545

Closed
rianhughes opened this issue Mar 27, 2024 · 1 comment
Closed

linter #545

rianhughes opened this issue Mar 27, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@rianhughes
Copy link
Contributor

Raising this issue again, as a linter would be very useful for the repo.
@rianhughes rianhughes added the good first issue Good for newcomers label Mar 27, 2024
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Mar 27, 2024
@nsiregar
[NethermindEth#545] Add golang linter
b837e65
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Mar 27, 2024
@nsiregar
[NethermindEth#545] fix linter error
679ba17
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Mar 27, 2024
@nsiregar
[NethermindEth#545] fix linter error
fc8c24a
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Mar 27, 2024
@nsiregar
[NethermindEth#545] remove unused config value
103d95f
@nsiregar nsiregar mentioned this issue Mar 27, 2024
Merged
@nsiregar
Copy link
Contributor

Hi @rianhughes , I created PR for this issue at #546 could you please review

nsiregar added a commit to nsiregar/starknet.go that referenced this issue Apr 1, 2024
@nsiregar
[NethermindEth#545] Add golang linter
cba2cf2
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Apr 1, 2024
@nsiregar
[NethermindEth#545] fix linter error
9662978
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Apr 1, 2024
@nsiregar
[NethermindEth#545] remove unused config value
d17e4ae
nsiregar added a commit to nsiregar/starknet.go that referenced this issue Apr 1, 2024
@nsiregar
[NethermindEth#545] Add golangci-lint and fix linter issues
3342c41
rianhughes added a commit that referenced this issue Apr 2, 2024
@nsiregar @rianhughes
#545 Add golangci-lint workflow (#546)
099cbdf 
[#545] Add golangci-lint and fix linter issues

Co-authored-by: Rian Hughes <ryanhughes4500@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
[Nubia] Starknet.go
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsiregar @rianhughes