-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds less severity for WIP and Draft pull requests #62
base: master
Are you sure you want to change the base?
Conversation
Let's see if this turns at least drafts green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we need to move calling danger to a Github action to run this script and stop using Peril (the web service) as
- this will give us more options in danger.
- we should be able to replace ALL functionality that the "ruby" dangerfile is doing and put it all in this one file
- have milestone and demilestoned events actually work (they do not work in Peril due to Github webhooks being incorrect and Github refusing to fix it)
- the developer of danger is no longer maintaining peril since his employer (microsoft) won't let him run Peril on their github account so all his effert is focused on a github actions run of danger.
@urkle I just want to be able to get green notification if my code is correct. |
You code looks fine, which I approved. We should, however, log a task to move this from Peril to a GH action. |
@firedev Please ping #release-managers to release an update. |
if (labels.includes('work in progress') || danger.git.commits.find(c => c && c.message.includes('WIP'))) { | ||
fail("PR is a Work in Progress"); | ||
failNonDraft("PR is a Work in Progress"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayarotsky @urkle
Won't this change result in a warn or a fail all the time?
The original check was to fail only IF it was a WIP, but this changes unconditionally will generate either a fail(msg) or a warn(msg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eakoli @ayarotsky We will release once the code review pass
Let's see if this turns at least drafts green
Change description
Instead of
fail
it will usewarn
fordraft
andWIP
pull requests