build(deps): bump node.js from 16 to 18 (#187)

NeuraLegion · Feb 3, 2023 · fbac2dd · fbac2dd
1 parent 4458a0a
commit fbac2dd
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 24 deletions.
diff --git a/.github/workflows/auto-build.yml b/.github/workflows/auto-build.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 
@@ -30,7 +30,7 @@ jobs:
         target: ['lint', 'format', 'build', 'test', 'e2e']
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/composite/npm/action.yml b/.github/workflows/composite/npm/action.yml
@@ -16,7 +16,7 @@ runs:
     - name: Set Node.js
       uses: actions/setup-node@v3
       with:
-        node-version: 16
+        node-version: 18
         cache: 'npm'
         registry-url: ${{ inputs.registry }}
         scope: ${{ inputs.scope }}

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -13,7 +13,7 @@ jobs:
   install-deps:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           ref: ${{ env.TARGET_REF }}
           token: ${{ secrets.GPR_TOKEN }}
@@ -25,7 +25,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: install-deps
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           ref: ${{ env.TARGET_REF }}
           token: ${{ secrets.GPR_TOKEN }}
@@ -50,7 +50,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: build
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           ref: ${{ env.TARGET_REF }}
           token: ${{ secrets.GPR_TOKEN }}
@@ -71,7 +71,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: build
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           ref: ${{ env.TARGET_REF }}
           token: ${{ secrets.GPR_TOKEN }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -9,7 +9,7 @@ jobs:
   release:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           token: ${{ secrets.GPR_TOKEN }}
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -65,7 +65,7 @@
     "@types/express": "^4.17.15",
     "@types/har-format": "^1.2.8",
     "@types/jest": "^29.2.4",
-    "@types/node": "~16.11.57",
+    "@types/node": "~18.11.18",
     "@types/webpack": "^5.28.0",
     "@types/webpack-node-externals": "^2.5.3",
     "@types/ws": "^8.5.4",

diff --git a/src/network/DefaultHarExporter.spec.ts b/src/network/DefaultHarExporter.spec.ts
@@ -93,7 +93,6 @@ describe('DefaultHarExporter', () => {
   describe('write', () => {
     it('should write the entry to the buffer', async () => {
       // arrange
-      // @ts-expect-error type mismatch
       when(streamMock.closed).thenReturn(false);
       when(optionsSpy.filter).thenReturn(predicate);
       predicate.mockReturnValue(false);
@@ -107,7 +106,6 @@ describe('DefaultHarExporter', () => {
 
     it('should write the entry to the buffer if the predicate returns throws an error', async () => {
       // arrange
-      // @ts-expect-error type mismatch
       when(streamMock.closed).thenReturn(false);
       when(optionsSpy.filter).thenReturn(predicate);
       predicate.mockReturnValue(
@@ -125,7 +123,6 @@ describe('DefaultHarExporter', () => {
       // arrange
       const entry = { foo: 'bar' } as unknown as Entry;
       const entryString = JSON.stringify(entry);
-      // @ts-expect-error type mismatch
       when(streamMock.closed).thenReturn(false);
       when(optionsSpy.transform).thenReturn(transform);
       transform.mockReturnValue(Promise.resolve(entry));
@@ -139,7 +136,6 @@ describe('DefaultHarExporter', () => {
 
     it('should skip the entry when the transformation is failed with an error', async () => {
       // arrange
-      // @ts-expect-error type mismatch
       when(streamMock.closed).thenReturn(false);
       when(optionsSpy.transform).thenReturn(transform);
       transform.mockReturnValue(
@@ -155,7 +151,6 @@ describe('DefaultHarExporter', () => {
 
     it('should not write the entry to the buffer if the predicate returns true', async () => {
       // arrange
-      // @ts-expect-error type mismatch
       when(streamMock.closed).thenReturn(false);
       when(optionsSpy.filter).thenReturn(predicate);
       predicate.mockReturnValue(true);
@@ -169,7 +164,6 @@ describe('DefaultHarExporter', () => {
 
     it('should not write the entry to the buffer if the buffer is closed', async () => {
       // arrange
-      // @ts-expect-error type mismatch
       when(streamMock.closed).thenReturn(true);
       when(optionsSpy.filter).thenReturn(predicate);
       predicate.mockReturnValue(false);

diff --git a/src/network/DefaultHarExporter.ts b/src/network/DefaultHarExporter.ts
@@ -43,7 +43,6 @@ export class DefaultHarExporter implements HarExporter {
 
     const json = await this.serializeEntry(entry);
 
-    // @ts-expect-error type mismatch
     if (!this.buffer.closed && json) {
       this.buffer.write(`${json}${EOL}`);
     }