fix(editor): retrieve parameter default value from dereferenced spec #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 92deeb5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.7% (0.0% change). View more on Code Climate. |
ostridm
force-pushed
the
fix-#212/retrieve-parameter-default-value-from-dereferenced-spec-instance
branch
2 times, most recently
from
a7aa43e
to
8acb8b2
Compare
pmstss
requested changes
Sep 20, 2023
There was a problem hiding this comment.
This PR fixes two pretty different issues:
parseBodyParameter()behavior in case of default value stored in referenced definition, as reflected in title. This part looks good.- unhandled root-level
consumesbriefly mentioned in issue description. This part is not covered in fixtures, as imo at least three cases must be there:
- root level
consumesand no operation-levelconsumes - root level
consumesoverriding with non-empty operation-levelconsumes - root level
consumesoverriding with empty operation-levelconsumes; according to spec - "An empty value MAY be used to clear the global definition".
Could you please rework this PR to cover only first intention and prepare new issue and PR to cover the second intention?
ostridm
force-pushed
the
fix-#212/retrieve-parameter-default-value-from-dereferenced-spec-instance
branch
from
8acb8b2
to
92deeb5
Compare
pmstss
approved these changes
Sep 20, 2023
ostridm
deleted the
fix-#212/retrieve-parameter-default-value-from-dereferenced-spec-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #212