Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sampler): introduce minLength support for string pattern format sample #217

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Sep 25, 2023

closes #216

@ostridm ostridm added the Type: bug Something isn't working. label Sep 25, 2023
@ostridm ostridm requested a review from pmstss September 25, 2023 07:18
@ostridm ostridm self-assigned this Sep 25, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 25, 2023

Code Climate has analyzed commit acf4cc2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.8% (0.0% change).

View more on Code Climate.

@ostridm ostridm enabled auto-merge (squash) September 25, 2023 07:22
ostridm added a commit that referenced this pull request Oct 6, 2023
@ostridm ostridm force-pushed the fix-#216/introduce-min-length-support-for-string-pattern-format-sample branch from 3e0f1de to acf4cc2 Compare October 6, 2023 10:19
@ostridm ostridm requested a review from pmstss October 6, 2023 10:32
Copy link
Contributor

@pmstss pmstss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid doing force pushes after review started in next prs

@ostridm ostridm merged commit d7f1a96 into master Oct 10, 2023
4 checks passed
@ostridm ostridm deleted the fix-#216/introduce-min-length-support-for-string-pattern-format-sample branch October 10, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pattern string sampler does not take into account minLength property
2 participants