Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace domain in links for documentation #18

Merged
merged 8 commits into from
Apr 25, 2022
Merged

docs: replace domain in links for documentation #18

merged 8 commits into from
Apr 25, 2022

Conversation

UncleVic
Copy link
Contributor

closes #17

@UncleVic UncleVic self-assigned this Apr 20, 2022
@UncleVic UncleVic added the documentation Improvements or additions to documentation label Apr 20, 2022
denis-novozhilov-neuralegion
denis-novozhilov-neuralegion reviewed Apr 20, 2022
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned a couple of places but I think the same question is applicable everywhere: what is the correct wording? Bright, BrightSec or Brightsec

LICENSE Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
denis-novozhilov-neuralegion
denis-novozhilov-neuralegion previously approved these changes Apr 21, 2022
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check the examples in README

@UncleVic UncleVic requested a review from derevnjuk April 21, 2022 13:14
@derevnjuk derevnjuk merged commit 3a55a34 into master Apr 25, 2022
@derevnjuk derevnjuk deleted the docs-#17/replace-domain-in-links-for-documentation branch April 25, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derevnjuk derevnjuk derevnjuk approved these changes

@denis-novozhilov-neuralegion denis-novozhilov-neuralegion denis-novozhilov-neuralegion approved these changes

Assignees

@UncleVic UncleVic

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace domain in links for documentation
3 participants
@UncleVic @derevnjuk @denis-novozhilov-neuralegion