-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Butterworth supports sosfiltfilt filter_function #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdenker
reviewed
Jul 9, 2019
mdenker
reviewed
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, could be quite helpful. I added two minor remarks about a comment and the doc string.
I could confirm this function now works with the notebook originally submitted in #220 |
mdenker
approved these changes
Jul 10, 2019
dizcza
added a commit
to INM-6/elephant
that referenced
this pull request
Aug 1, 2019
commit 19d3c7b Author: Danylo Ulianych <dizcza@gmail.com> Date: Thu Aug 1 15:09:34 2019 +0200 fixed min requirements (NeuralEnsemble#235) * fixed min requirements * travis install libopenmpi-dev * added .coveragerc omit=elephant/test* rule not to count test files as source code commit 36e6096 Author: Danylo Ulianych <dizcza@gmail.com> Date: Wed Jul 31 16:55:47 2019 +0200 Integrated GPFA (NeuralEnsemble#233) * Rename neural_trajectory to gpfa and refactor the codes accordingly * Remove codes related to the (not fully implemented) cross-validation feature * added tqdm as an extra requirement * push coverage only for requirements-extras test * gpfa verbose flag; added licence in the docs * Fixed and extended documentation, removed misleading function outputs. commit d6822d6 Author: Danylo Ulianych <dizcza@gmail.com> Date: Tue Jul 23 16:35:45 2019 +0300 Acknowledgments (NeuralEnsemble#241) * acknowledgments * removed reference file AUTHORS.txt * recursive-exclude . *~ commit 6fd3a5b Author: Danylo Ulianych <dizcza@gmail.com> Date: Mon Jul 22 23:14:36 2019 +0300 Release v0.6.3 (NeuralEnsemble#240) * Release v0.6.3 * Update doc/reference/waveform_features.rst Co-Authored-By: Michael Denker <m.denker@fz-juelich.de> commit c013e39 Author: Danylo Ulianych <dizcza@gmail.com> Date: Sun Jul 21 09:18:03 2019 +0300 elephant dir packages are back (NeuralEnsemble#239) * reverted removed imports of elephant's internal packages; download fim during the setup * download fim from tools/fim_manager.py * dummy tools/__init__.py to support py2 * include requirements in MANIFEST back * fixed spade licence typo * included waveform_features module; removed tools; don't donwload fim at setup while macking a tarball with 'sdist' command travis not fixed downloading fim * skip time consuming test_spade_cpp if not HAVE_FIM * travis pip install generated tarball * recursive-include elephant *.py commit 3c30574 Author: Danylo Ulianych <dizcza@gmail.com> Date: Wed Jul 10 18:21:37 2019 +0200 Butterworth supports sosfiltfilt filter_function (NeuralEnsemble#234) * Butterworth supports sosfiltfilt filter_function * higher order filters comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220.