Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Butterworth supports sosfiltfilt filter_function #234

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Butterworth supports sosfiltfilt filter_function #234

merged 2 commits into from
Jul 10, 2019

Conversation

dizcza
Copy link
Member

@dizcza dizcza commented Jul 5, 2019

Fixes #220.

@pep8speaks
Copy link

pep8speaks commented Jul 5, 2019 •
edited
Loading

Hello @dizcza! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-10 13:18:17 UTC

@dizcza dizcza mentioned this pull request Jul 5, 2019
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jul 5, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 70.976% when pulling 669ff49 on INM-6:butter into 5dfdab9 on NeuralEnsemble:master.

@dizcza dizcza requested a review from mdenker July 5, 2019 15:08
@mdenker mdenker added this to the v0.7.0 milestone Jul 8, 2019
mdenker
mdenker reviewed Jul 10, 2019
View reviewed changes
Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, could be quite helpful. I added two minor remarks about a comment and the doc string.

elephant/signal_processing.py Show resolved Hide resolved
@mdenker mdenker added the enhancement Editing an existing module, improving something label Jul 10, 2019
@mdenker
Copy link
Member

mdenker commented Jul 10, 2019

I could confirm this function now works with the notebook originally submitted in #220

@mdenker mdenker merged commit 3c30574 into NeuralEnsemble:master Jul 10, 2019
dizcza added a commit to INM-6/elephant that referenced this pull request Aug 1, 2019
@dizcza
Squashed commit of the following:
2c49122 
commit 19d3c7b
Author: Danylo Ulianych <dizcza@gmail.com>
Date:   Thu Aug 1 15:09:34 2019 +0200

    fixed min requirements (NeuralEnsemble#235)

    * fixed min requirements

    * travis install libopenmpi-dev

    * added .coveragerc omit=elephant/test* rule not to count test files as source code

commit 36e6096
Author: Danylo Ulianych <dizcza@gmail.com>
Date:   Wed Jul 31 16:55:47 2019 +0200

    Integrated GPFA (NeuralEnsemble#233)

    * Rename neural_trajectory to gpfa and refactor the codes accordingly

    * Remove codes related to the (not fully implemented) cross-validation feature

    * added tqdm as an extra requirement

    * push coverage only for requirements-extras test

    * gpfa verbose flag; added licence in the docs

    * Fixed and extended documentation, removed misleading function outputs.

commit d6822d6
Author: Danylo Ulianych <dizcza@gmail.com>
Date:   Tue Jul 23 16:35:45 2019 +0300

    Acknowledgments (NeuralEnsemble#241)

    * acknowledgments

    * removed reference file AUTHORS.txt

    * recursive-exclude . *~

commit 6fd3a5b
Author: Danylo Ulianych <dizcza@gmail.com>
Date:   Mon Jul 22 23:14:36 2019 +0300

    Release v0.6.3 (NeuralEnsemble#240)

    * Release v0.6.3

    * Update doc/reference/waveform_features.rst

    Co-Authored-By: Michael Denker <m.denker@fz-juelich.de>

commit c013e39
Author: Danylo Ulianych <dizcza@gmail.com>
Date:   Sun Jul 21 09:18:03 2019 +0300

    elephant dir packages are back (NeuralEnsemble#239)

    * reverted removed imports of elephant's internal packages; download fim during the setup

    * download fim from tools/fim_manager.py

    * dummy tools/__init__.py to support py2

    * include requirements in MANIFEST back

    * fixed spade licence typo

    * included waveform_features module; removed tools; don't donwload fim at setup while macking a tarball with 'sdist' command

    travis not fixed downloading fim

    * skip time consuming test_spade_cpp if not HAVE_FIM

    * travis pip install generated tarball

    * recursive-include elephant *.py

commit 3c30574
Author: Danylo Ulianych <dizcza@gmail.com>
Date:   Wed Jul 10 18:21:37 2019 +0200

    Butterworth supports sosfiltfilt filter_function (NeuralEnsemble#234)

    * Butterworth supports sosfiltfilt filter_function

    * higher order filters comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdenker mdenker mdenker approved these changes

Assignees
No one assigned
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Butterworth filtering and theta bandpass
4 participants
@dizcza @pep8speaks @coveralls @mdenker