fixed min requirements #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something to include in 0.6.3, or rather in 0.7? I approved, but did not merge. |
mdenker
approved these changes
Jul 21, 2019
|
I suggest merging this PR after we release v0.6.3 since the requirements are changed a lot. |
dizcza
added a commit
to INM-6/elephant
that referenced
this pull request
Aug 1, 2019
commit 19d3c7b Author: Danylo Ulianych <dizcza@gmail.com> Date: Thu Aug 1 15:09:34 2019 +0200 fixed min requirements (NeuralEnsemble#235) * fixed min requirements * travis install libopenmpi-dev * added .coveragerc omit=elephant/test* rule not to count test files as source code commit 36e6096 Author: Danylo Ulianych <dizcza@gmail.com> Date: Wed Jul 31 16:55:47 2019 +0200 Integrated GPFA (NeuralEnsemble#233) * Rename neural_trajectory to gpfa and refactor the codes accordingly * Remove codes related to the (not fully implemented) cross-validation feature * added tqdm as an extra requirement * push coverage only for requirements-extras test * gpfa verbose flag; added licence in the docs * Fixed and extended documentation, removed misleading function outputs. commit d6822d6 Author: Danylo Ulianych <dizcza@gmail.com> Date: Tue Jul 23 16:35:45 2019 +0300 Acknowledgments (NeuralEnsemble#241) * acknowledgments * removed reference file AUTHORS.txt * recursive-exclude . *~ commit 6fd3a5b Author: Danylo Ulianych <dizcza@gmail.com> Date: Mon Jul 22 23:14:36 2019 +0300 Release v0.6.3 (NeuralEnsemble#240) * Release v0.6.3 * Update doc/reference/waveform_features.rst Co-Authored-By: Michael Denker <m.denker@fz-juelich.de> commit c013e39 Author: Danylo Ulianych <dizcza@gmail.com> Date: Sun Jul 21 09:18:03 2019 +0300 elephant dir packages are back (NeuralEnsemble#239) * reverted removed imports of elephant's internal packages; download fim during the setup * download fim from tools/fim_manager.py * dummy tools/__init__.py to support py2 * include requirements in MANIFEST back * fixed spade licence typo * included waveform_features module; removed tools; don't donwload fim at setup while macking a tarball with 'sdist' command travis not fixed downloading fim * skip time consuming test_spade_cpp if not HAVE_FIM * travis pip install generated tarball * recursive-include elephant *.py commit 3c30574 Author: Danylo Ulianych <dizcza@gmail.com> Date: Wed Jul 10 18:21:37 2019 +0200 Butterworth supports sosfiltfilt filter_function (NeuralEnsemble#234) * Butterworth supports sosfiltfilt filter_function * higher order filters comment
dizcza
added a commit
to INM-6/elephant
that referenced
this pull request
Aug 13, 2019
commit caa2110 Author: Danylo Ulianych <dizcza@gmail.com> Date: Tue Aug 13 10:03:45 2019 +0300 explain and ignore warnings during the tests (NeuralEnsemble#238) * explain and ignore warnings during the tests * scipy v0.18.0 * fixed min-req tests: scipy v0.19.0 * exclude min-requirements tests back * fixed division by zero commit 19d3c7b Author: Danylo Ulianych <dizcza@gmail.com> Date: Thu Aug 1 15:09:34 2019 +0200 fixed min requirements (NeuralEnsemble#235) * fixed min requirements * travis install libopenmpi-dev * added .coveragerc omit=elephant/test* rule not to count test files as source code commit 36e6096 Author: Danylo Ulianych <dizcza@gmail.com> Date: Wed Jul 31 16:55:47 2019 +0200 Integrated GPFA (NeuralEnsemble#233) * Rename neural_trajectory to gpfa and refactor the codes accordingly * Remove codes related to the (not fully implemented) cross-validation feature * added tqdm as an extra requirement * push coverage only for requirements-extras test * gpfa verbose flag; added licence in the docs * Fixed and extended documentation, removed misleading function outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the min package requirements versions are broken. I found the corresponding issue #10.
This commit fixes it and includes "pip 3.6 requirements-extras min version" test in travis to make sure we will not break dependencies again.
DataFrame.sort_index(level=...)was introduced in pandas v0.18.0.One problem that I see now is that "pip 3.6 requirements-extras min version" test case takes 20 minutes while the other ones finish in less than 10 min. Building numpy, scipy and pandas old versions takes a lot of time. This is the caveat that is thankfully avoided in later and up-to-date versions. Consider excluding this test once again if that will harden the continuous development and integration.
I also added
.coveragercfile to ignore tests from being counted as source code when the coverage command is run.