Rescale raw signals only in real_scale mode #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgarcia
reviewed
Jul 2, 2019
|
I think we can go for this. |
|
I think that this solution is probably better for the library than #44. It fixes the scaling issue when it matters (real_scale mode) and doesn't do unnecessary scaling in other modes. Using this instead of #44 means I'll have to do a little extra work in my app, but that's OK. The library should perform well. I will merge. 😊 |
|
P.S.: Thanks for the review! |
jpgill86
added a commit
to jpgill86/neurotic
that referenced
this pull request
Jul 2, 2019
Needed for compatibility with NeuralEnsemble/ephyviewer#56
jpgill86
added a commit
to jpgill86/ephyviewer
that referenced
this pull request
Jul 9, 2019
Fixes NeuralEnsemble#58. Added new `raw_gains` and `raw_offsets` to `TraceViewer_ParamController`, which are distinguished from the adjustable `gains` and `offsets` parameters. For raw signal sources, these values are obtained from the RawIO header. For in-memory signal sources, `raw_gains` = 1 and `raw_offsets` = 0. New properties `total_gains` and `total_offsets` are added which provide the combined raw and adjustable gains and offsets. In the case of `total_offsets`, this is not simply the sum as you might expect (see detailed comments for explanation). Parameters to functions that require the total gains and offsets (`get_data` and `on_request_data`) were renamed to avoid confusion. Distinguishing between raw and adjustable gains and offsets makes it easier to properly place the trace labels and baselines at each trace's zero for both raw and in-memory sources. Due to this new division of labor, changes made to `compute_rescale` in NeuralEnsemble#56 are effectively reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a response to #44 and is what I was referring to here: #44 (comment)