Add more cell helpers #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get segments matching a string - get segment group by id - get segment groups matching a string
sanjayankur31
force-pushed
the
feat/more-cell-helpers
branch
from
de966cf
to
a42863c
Compare
|
Just minor, but if it's possible that multiple segments or segment groups will be returned (not just one), it should probably be reflected in the method name, i.e. get_segments_by_substring, get_segment_groups_by_substring |
|
Sure, updated ^ |
|
Thanks! |
sanjayankur31
added a commit
to NeuroML/pyNeuroML
that referenced
this pull request
Jul 26, 2022
This is required because the CellBuilder uses methods that were only added to libNeuroML in version 0.3.1. Reference: NeuralEnsemble/libNeuroML#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #104 to be merged first, since that also regenerates nml.py.