New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/py2 stringio #118

Merged

sanjayankur31 merged 2 commits into development from fix/py2-stringio

Nov 26, 2021

Contributor

sanjayankur31 commented Nov 26, 2021

No description provided.

sanjayankur31 added 2 commits

November 26, 2021 13:40


          Revert "fix: py2 build"

fb74540

This reverts commit aa025c6.


          fix: correctly fix py2/3 StringIO error

fcdcd56

In python 2, we must use `from StringIO import StringIO` for strings.
This is not the same as `from io import StringIO` in Python2 (or in
Python3).

The former handles strings, the latter handles unicode. For Py2, since
we're not prefixing all strings with `u""` to make them unicode, we need
to use the first one.

So, different `StringIO` classes need to be imported for Python2 and
Python3. The same `from io import StringIO` cannot be shared.

- https://docs.python.org/2.7/library/stringio.html?highlight=stringio#StringIO.StringIO
- https://docs.python.org/2.7/library/io.html?highlight=io%20stringio#io.StringIO

sanjayankur31 added the T: bug label

sanjayankur31 merged commit 04a359a into development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment