Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nml.py): add level 2 validation for SegmentGroup #156

Draft
wants to merge 16 commits into
base: development
Choose a base branch
from
Draft

feat(nml.py): add level 2 validation for SegmentGroup #156

wants to merge 16 commits into from

Conversation

sanjayankur31
Copy link
Contributor

This also sets up a general framework for us to add more tests in libNeuroML.

@sanjayankur31
feat(nml.py): add level 2 validation for SegmentGroup
aaddfa8 
This also sets up a general framework for us to add more tests in
libNeuroML.
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Dec 2, 2022
@sanjayankur31 sanjayankur31 self-assigned this Dec 2, 2022
@sanjayankur31
Copy link
Contributor Author

To make these self-contained and not dependent on nml.py, we want to:

  • split them out into a new module
  • use a consistent class framework so that these can be called from anywhere
  • let generateds import this module and use it in nml.py

@sanjayankur31 sanjayankur31 added the S: waiting for reporter Waiting for reporter to respond label Dec 5, 2022
@sanjayankur31
Merge branch 'development' into feat/add-l2-validation-segmentgroup
7415950
@sanjayankur31
feat(l2testing): add framework for level 2 validation tests
8b2eaa0
@sanjayankur31
test(l2validators): add initial set of tests
87c2461
@sanjayankur31
feat(l2validator): remove duplicate SegmentGroup validation test
c9feacb
@sanjayankur31
feat(l2validator): allow validation of objects by arbitrary test classes
f42bdeb 
This is so that an object of class A may also be tested with tests
defined for its ancestors. It is the developer's responsibility to
ensure that only the right tests are run for a particular object.

With great power, comes great responsibility!
@sanjayankur31
test(l2validator): add test for segment group including itself
9260309
@sanjayankur31
fix(l2validator): pass tests that are marked as warnings
46893e3
@sanjayankur31
feat(generatedssuper): print out remaining collected messsages
e5088fd 
When a validation test fails, we error immediately and print out the
validation error. However, if a test that's marked for warnings, not
errors fails, we don't error immediately, but we do print out the
collected warnings.
@sanjayankur31
chore(cell-helper): add todo to deduplicate based on contents also
b19c94d
@sanjayankur31
test(l2validator): add more tests
14c4554
@sanjayankur31
fix(test-cell-optimise): correctly add duplicates of same object
cd28d71 
The test was wrong, but not sure why it passed before. Each new Include
object is completely different, and would not count as a duplicate.

TODO: check this again and pin down why behaviour changed after addition
of l2validator test
@sanjayankur31
WIP: performance drops need investigation
518f294
@sanjayankur31 sanjayankur31 marked this pull request as draft February 9, 2023 10:46
@sanjayankur31 sanjayankur31 mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgleeson pgleeson Awaiting requested review from pgleeson

Assignees

@sanjayankur31 sanjayankur31

Labels
S: waiting for reporter Waiting for reporter to respond T: enhancement Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sanjayankur31