SpikeGLX: add Ultra and NP-Opto types #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine to me. Are there any test files that could help us double check that adding just there works (other than seeing that it seemed to work in the issue)? |
|
I don't have any, but it should be fine :) |
zm711
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
@CodyCBakerPhD would you give confirmation this works on your side?
It looks good to me, but since we don't have something to test, it would be nice to have confirmation in the PR itself.
|
Test data uploaded here: https://gin.g-node.org/NeuralEnsemble/ephy_testing_data/pulls/129 @zm711 could you check (and merge) the GIN PR? |
|
Merged :) and just reran tests. |
zm711
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1451
also adding Ultra-beta variant (1121) ant NP-Opto (1300). All these models are based on NP1.0 technology
@CodyCBakerPhD