Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Nullified hyperparameter (by unused optional steps) to be returnable as keys in a method of class HyperparamSamples #254

Closed
guillaume-chevalier opened this issue Feb 8, 2020 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@guillaume-chevalier
Copy link
Member

We need def HyperparamSamples.get_nullified_keys to remember which hyperparams were nullified by the Optional and ChooseOneOf classes, ChoosManyOf, etc.

hp = step.get_hyperparams()

dict_with_double_underscores = hp.to_flat_dict()

the_keys_of_the_double_underscores_that_were_nullified_this_time = hp.get_nullified_keys()

dict_with_double_underscores.remove(the_keys_of_the_double_underscores_that_were_nullified_this_time)

This is needed for the TPE @alexbrillant @Eric2Hamel

Me or Alex should start this or do this on 11 feb or approx.

@vincent-antaki
Copy link
Contributor

@guillaume-chevalier, I know TPE has been implemented, has this been implemented too?

@guillaume-chevalier
Copy link
Member Author

guillaume-chevalier commented Jan 27, 2021

Not yet! TPE is working but it was also amidst a refactor. @vincent-antaki

@stale
Copy link

stale bot commented Aug 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 180 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 2, 2022
@stale stale bot closed this as completed Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants