Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove narrow_space_from_best_guess function for HyperparameterSpace, and find alternative to nullify #447

Closed
vincent-antaki opened this issue Feb 17, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vincent-antaki
Copy link
Contributor

HyperparameterSpace has two function which aren't used, or tested, anywhere (nullify and narrow_space_from_best_guess). I believe they may be remnant of old hyperparameter research strategy. In my humble opinion, they should be removed. or at the very least moved to a class which implement the hyperparam research strategy interface.

@guillaume-chevalier
Copy link
Member

Nice catch. narrow_space_from_best_guess should be removed without further questionning. Note that it is explained in some documentation example notebooks on the sphinx site, so the according documentation shall be removed as well upon doing this.

For the nullify method, I think that despite this method may seem available, that it may not work properly already. If done correctly, nullifying could be an indicator for the TPE of which Optional(step...) variables to ignore (or consider) for certain trials into how it accounted, or not, in the score obtained. Other hyperparameter selection strategies we would further code could make use of nullified params as well.

If we remove the idea of nullifying some params, we need a replacement for indicating which parameters are nullified from optionals. Perhaps a new apply method like pipeline.get_nullified_hyperparams() which only optionals would implement, and which would be useable by (or sent to) the TPE ?

@vincent-antaki

@guillaume-chevalier guillaume-chevalier changed the title Feature: Remove nullify function for HyperparameterSpace Feature: Remove narrow_space_from_best_guess function for HyperparameterSpace, and find alternative to nullify Feb 21, 2021
@guillaume-chevalier
Copy link
Member

Related: #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants