Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: StepSaverCallback & BestModelCheckpoint not working in version 0.7.0 #522

Closed
guillaume-chevalier opened this issue Feb 10, 2022 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on

Comments

@guillaume-chevalier
Copy link
Member

Describe the bug
From version 0.7.0 and later, these callbacks don't have access to the pipeline anymore since the pipeline isn't stored anymore in the TrialSplit, but just in the AutoML class.

To Reproduce
Update to 0.7.0 and run these tests that are skipped.

Expected behavior
Callbacks are supposed to log models using the repo.

Suggested Fix
Possibly have the TrialSplits contain their trained model again, instead of letting the Trainer call the model.

Additional context
0.7.0 is not merged nor deployed at the moment of writing this issue.

@guillaume-chevalier guillaume-chevalier added bug Something isn't working invalid This doesn't seem right labels Feb 10, 2022
guillaume-chevalier added a commit to Kimoby/Neuraxle that referenced this issue Feb 11, 2022
@stale
Copy link

stale bot commented Aug 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 180 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 16, 2023
@stale stale bot closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant