New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trial Validation Split In AutoML Loop #295
Conversation
…nto trial-repo-split
|
||
time_a = time.time() | ||
auto_ml = AutoML( | ||
pipeline, | ||
refit_trial=False, | ||
refit_trial=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already made the comment in the bast, but it'd be good to provide some example comment for the time printed so that readers can realize how faster it is. Optional fix.
BaseValidationSplitter.__init__(self) | ||
self.k_fold = k_fold | ||
|
||
def split(self, data_inputs, expected_outputs=None) -> Tuple[List, List, List, List]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe def __call__
instead? This would allow for passing functions as well as splitters. Idk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to do this, and failed. I think it's fine like this tbh
Add Trial Validation Split In AutoML Loop
Add Trial Validation Split In AutoML Loop
What it is
My pull request does: Add a trial split to the trial data container.
How it works
I coded it this way:
Example usage
Here is how it is used in the AutoML loop class: