Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Pass context in setup #365 #366

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

alexbrillant
Copy link
Contributor

No description provided.

Copy link
Member

@guillaume-chevalier guillaume-chevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use none as default to avoid breaking changes and I can merge: def setup(self, context: ExecutionContext = None)

Copy link
Member

@guillaume-chevalier guillaume-chevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

@alexbrillant alexbrillant merged commit 21215e2 into Neuraxio:master Jul 20, 2020
@alexbrillant alexbrillant deleted the setup-with-context branch July 20, 2020 00:05
alexbrillant added a commit to alexbrillant/Neuraxle that referenced this pull request Sep 3, 2020
alexbrillant added a commit to alexbrillant/Neuraxle that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants