Python 3 compatible getneuroML file #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to setup jNeuroML from source in a python3 environment and getNeuroml.py file posed an issue as it is not python 3 compatible. Although its functionality is just to setup repos for jNeuroML which is still possible via python2, but it would be great if we don't have to switch python for using it.
I changed few things to make it python 2+3 compatible.
There are multiple empty print statements that can be replaced by \n but I haven't changed to keep this PR minimal.
Also I noticed that setting up jNeuroML from source with java 9 throw error with
jdx
lib. As per my research we need to update the minimum ersion of this lib to 2.2, still there are other issues with java 9 compatibility.It would be great if you can mention that
use java 8 to build from source
on readme file. I can make a commit if you want.