Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatible getneuroML file #57

Merged
merged 2 commits into from
May 8, 2018
Merged

Conversation

kapilkd13
Copy link
Contributor

@kapilkd13 kapilkd13 commented Apr 28, 2018

I was trying to setup jNeuroML from source in a python3 environment and getNeuroml.py file posed an issue as it is not python 3 compatible. Although its functionality is just to setup repos for jNeuroML which is still possible via python2, but it would be great if we don't have to switch python for using it.
I changed few things to make it python 2+3 compatible.

  • imported print from future
  • removed unordered use of tabs and spaces for indentation
  • resolved bytes for str error
    There are multiple empty print statements that can be replaced by \n but I haven't changed to keep this PR minimal.

Also I noticed that setting up jNeuroML from source with java 9 throw error with jdx lib. As per my research we need to update the minimum ersion of this lib to 2.2, still there are other issues with java 9 compatibility.
It would be great if you can mention that use java 8 to build from source on readme file. I can make a commit if you want.

@pgleeson
Copy link
Member

Thanks. Will check through it.

@pgleeson pgleeson merged commit a65b5b5 into NeuroML:master May 8, 2018
@pgleeson
Copy link
Member

pgleeson commented May 8, 2018

Thanks for this @kapilkd13. Some of these changes for python3 were already made on the development branch, but I've synced the changes for py3 compatibility between master and development now. By the way, to get the very latest jneuroml functionality I'd build from the development branches (highly recommended). This should just involve a local update of jnml, followed by:

python getNeuroML.py clean
python getNeuroML.py development

@kapilkd13 kapilkd13 deleted the py3 branch May 8, 2018 15:39
@kapilkd13
Copy link
Contributor Author

Thanks @pgleeson for this information. I will move to development branch.
As you might remember I would be working on "GSoC project #13.1: Import NeuroML morphologies" as you already helped me there with the valuable info. on parsing tools for NeuroML. I would be working with JneuroML, Pylems and libNeuroML and you are a core developer in all these repos. So I hope you would be able to help me in this project.
Till now I did some research on above mentioned libraries and as per me libNeuuroML best suits our need as it is light, developed in python and is focused on NeuroML. what do you think?

Also should I mail you or create an issue page on libNeuroML to discuss any further issues/ideas.

Thanks.

1 similar comment
@kapilkd13
Copy link
Contributor Author

Thanks @pgleeson for this information. I will move to development branch.
As you might remember I would be working on "GSoC project #13.1: Import NeuroML morphologies" as you already helped me there with the valuable info. on parsing tools for NeuroML. I would be working with JneuroML, Pylems and libNeuroML and you are a core developer in all these repos. So I hope you would be able to help me in this project.
Till now I did some research on above mentioned libraries and as per me libNeuuroML best suits our need as it is light, developed in python and is focused on NeuroML. what do you think?

Also should I mail you or create an issue page on libNeuroML to discuss any further issues/ideas.

Thanks.

@pgleeson
Copy link
Member

pgleeson commented May 9, 2018

Sure, libNeuroML seems like the best option for your project. You can mail me, but if it's a question thta others might have an issue on that repo would be best. I mentioned to @mstimberg that we could have a skype/hangout some time once you get going in the project for general questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants