Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -validate-sbml option #266

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Conversation

robertvi
Copy link

Also added sbml section to options.extras_require and a test script at tests/sbml/test_sbml.py. Running the main test.sh was taking too long so am not sure it will correctly handle the test.

@sanjayankur31
Copy link
Member

I'll tweak this to make it against development, since that's where the latest code lives.

@sanjayankur31 sanjayankur31 changed the base branch from master to development October 30, 2023 13:35
@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement S: ready for review Status: ready for review labels Oct 30, 2023
@sanjayankur31 sanjayankur31 linked an issue Oct 30, 2023 that may be closed by this pull request
@robertvi robertvi marked this pull request as ready for review October 31, 2023 08:47
@robertvi
Copy link
Author

hopefully ready for review and merging now

@pgleeson
Copy link
Member

Tested and looks good.

@pgleeson pgleeson merged commit 6c023c3 into NeuroML:development Nov 15, 2023
11 checks passed
@sanjayankur31
Copy link
Member

@all-contributors please add @robertvi for code,test

Copy link
Contributor

@sanjayankur31

I've put up a pull request to add @robertvi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: ready for review Status: ready for review T: enhancement Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to validate SBML
3 participants