Feat/recv2- Recording functionality #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by adding a new function record_video
…the 3D cell morphology
|
Hi sir @sanjayankur31. Can you take a look at this? |
sanjayankur31
requested changes
Apr 23, 2024
| @@ -14,7 +14,9 @@ | |||
| import math | |||
| import random | |||
| import typing | |||
|
|
|||
| import imageio | |||
There was a problem hiding this comment.
we need to add this to the setup.cfg too, under the vispy-common extra
| def stop_recording(canvas): | ||
| nonlocal recording, frames | ||
| recording = False | ||
| output_file = f"output-{len(glob.glob('output-*.mp4'))}.mp4" |
There was a problem hiding this comment.
we generated the name of the output file above already---can we not re-use that here also?
sanjayankur31
added
S: waiting on reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the create_new_vispy_canvas code to add video recording functionality