-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/recv2- Recording functionality #342
base: development
Are you sure you want to change the base?
Conversation
…by adding a new function record_video
…the 3D cell morphology
Hi sir @sanjayankur31. Can you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't currently work for me. Please see the comments (and test it out yourself to make sure it works)
@@ -14,7 +14,9 @@ | |||
import math | |||
import random | |||
import typing | |||
|
|||
import imageio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add this to the setup.cfg
too, under the vispy-common
extra
def stop_recording(canvas): | ||
nonlocal recording, frames | ||
recording = False | ||
output_file = f"output-{len(glob.glob('output-*.mp4'))}.mp4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we generated the name of the output file above already---can we not re-use that here also?
Updated the create_new_vispy_canvas code to add video recording functionality