-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused dependencies - review examples and tutorials #188
Conversation
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
The figshare issue is solved. I could remove the wfdb dependency. Also, I added the In order to ease the documentation building, I reduced the number of subjects use in the examples and tutorials. Also, I picked smaller datasets and tried to reuse the same datasets across examples to limit the number data to download. I corrected the Closes #77 |
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
This code is stable and is ready to merge. I tested it against all examples and tutorials. @jsosulski @v-goncharenko or @ErikBjare |
I can take a look on the weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aside from some minor comments. :) thanks
if (current - previous) > thres_split: | ||
sampleB = samples[i - 1] | ||
freqs.append(s // c) | ||
if (sampleB - sampleA) > 382: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is mamem specific, but why is the diff compared to 382?
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Ok, I'll merge this one! |
closes #180
This issue is connected with the problem in documentation generation #173 as wfdb silently fails to download the file and when the example code extracts MNE epochs from downloaded files, they are empty.
I contacted Dr. Spiridon Nikolopoulos, that posted the MAMEM dataset on figshare. Unfortunately, these are only big rar/zip files that contain .mat files for each session/subject. I worked on the figshare to upload the separate files, it is okay for MAMEM 2 and 3.
I added all the code to download and open mat files instead of wfdb format. The data and labels obtained with mat files are similar to those obtained with wfdb.
This PR also introduces some new code to download dataset without using MNE internal fetch function. As they told us, it would be deprecated. They recommend to use pooch. I added helper function in
download.py
to get FigShare file using pooch.There is still a problem with MAMEM 1 dataset, because of an internal error of FigShare. Maybe it is possible to merge this code without waiting for full support of the MAMEM 1.