-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTP protocol download support #9226
Comments
Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
@v-goncharenko we are already considering maybe getting rid of a lot of our file fetching code, and depending instead on pooch. Pooch supports FTP already. It might be worth seeing how easy it is to use |
FYI @v-goncharenko with #9742, we are moving forward with the creation of a general-MNE-purpose dataset fetcher that could be used by downstream packages potentially. |
Closing since this hopefully is now supported by |
Describe the new feature or enhancement
moabb
heavily usesmne
for processing data.Also all downloads are performed via
mne.utils._fetch_file
: see usage hereCurrently
moabb
has a dataset which files are stored on FTP server and available over this protocol.But
_fetch_file
fails with an error (see it here) becausemoabb
passes thisftp
urlDescribe your proposed implementation
Add
ftp
protocol support to_fetch_file
Describe possible alternatives
moabb
writes it's own download function (but it's nice to use existing one inmne
)Additional comments
Is it okay to use a function starting with underscore (
_
) in external code? Afaik no =)Maybe you have a public interface for this functionality?
The text was updated successfully, but these errors were encountered: