Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise runs and sessions names #471

Merged
merged 59 commits into from Oct 11, 2023

Conversation

PierreGtch
Copy link
Collaborator

  • Closes Normalise runs and sessions names #451
  • new naming convention: str of an integer corresponding to the run/session recording order (starting at 0), eventually followed by a description string (only containing letters and integers but not starting by an integer)
  • Adds a test in dataset.get_data that verifies if the runs and sessions and subjects are correctly named

@PierreGtch PierreGtch marked this pull request as ready for review August 28, 2023 07:52
@PierreGtch
Copy link
Collaborator Author

This comment will be removed from the code but is relatively important:

In the BIDS standard, the runs are expected to be indexes. This is not always the case in MOABB because we allow to append a description to the index. See: https://bids-specification.readthedocs.io/en/stable/glossary.html#run-entities

@bruAristimunha
Copy link
Collaborator

I liked it, but I'm unsure if this won't break something in the braindecode. Maybe we need to do something more activate. Add a little sub test routine or something else.

@bruAristimunha
Copy link
Collaborator

I will review the PR more carefully

@PierreGtch PierreGtch added this to the 1.0.0 milestone Aug 31, 2023
@PierreGtch
Copy link
Collaborator Author

Let’s normalise session and run suffixes to “test” and “train”.
For the special cases (soa, Cattan2019_VR), we keep them like that for now.

Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PierreGtch this is really a nice API breaking change ^^

@sylvchev
Copy link
Member

sylvchev commented Sep 8, 2023

closes #472

@sylvchev sylvchev linked an issue Sep 8, 2023 that may be closed by this pull request
@PierreGtch
Copy link
Collaborator Author

This is ready to merge @bruAristimunha @sylvchev

@bruAristimunha bruAristimunha enabled auto-merge (squash) October 3, 2023 23:11
@bruAristimunha
Copy link
Collaborator

Amazing work @PierreGtch. I need to pay you a beer =)

@bruAristimunha bruAristimunha merged commit a7f082e into NeuroTechX:develop Oct 11, 2023
4 of 6 checks passed
@gcattan
Copy link
Contributor

gcattan commented Oct 21, 2023

Missing update in bci_illiteracy:

image

@PierreGtch PierreGtch mentioned this pull request Oct 22, 2023
@PierreGtch
Copy link
Collaborator Author

Indeed, thanks @gcattan. I made a PR: #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible results between version 0.6 and earlier Normalise runs and sessions names
4 participants