Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to checkConfig utility function to remove null characters from column names of DynamicTable #366

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

cechava
Copy link
Collaborator

@cechava cechava commented Dec 14, 2021

fixes #365

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #366 (0c46872) into master (53965b6) will decrease coverage by 0.03%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   85.67%   85.64%   -0.04%     
==========================================
  Files         124      124              
  Lines        4615     4625      +10     
==========================================
+ Hits         3954     3961       +7     
- Misses        661      664       +3     
Impacted Files Coverage Δ
+types/+util/+dynamictable/checkConfig.m 91.80% <62.50%> (-4.43%) ⬇️
+tests/+system/DynamicTableTest.m 99.45% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53965b6...0c46872. Read the comment docs.

@lawrence-mbf lawrence-mbf self-requested a review December 15, 2021 15:37
@cechava cechava merged commit 410dc9c into NeurodataWithoutBorders:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatNWB does not ignore nullspace in column names when reading in DynamicTable objects from file
2 participants