Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove international datestring parsing for version checks #509

Merged
merged 4 commits into from
May 30, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #508

Motivation

See #508

How to test the behavior?

Using a non-US locale, attempt to call datetime(version('-date')). A local error occurs (see #508)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf changed the title 508 remove international datestring parsing Remove international datestring parsing May 26, 2023
@lawrence-mbf lawrence-mbf changed the title Remove international datestring parsing Remove international datestring parsing for version checks May 26, 2023
@lawrence-mbf lawrence-mbf self-assigned this May 26, 2023
- Also fixes tests.
@lawrence-mbf lawrence-mbf marked this pull request as ready for review May 26, 2023 14:41
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #509 (af0db0a) into master (43cdffb) will not change coverage.
The diff coverage is 87.17%.

@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         129      129           
  Lines        5451     5451           
=======================================
  Hits         4791     4791           
  Misses        660      660           
Impacted Files Coverage Δ
+io/parseDataset.m 83.33% <83.33%> (ø)
+tests/+unit/boolTest.m 95.83% <95.83%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf merged commit 92a65a3 into master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DateString Interpretation Error in io.parseDataset()
2 participants