Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end extension example for extending LabMetaData #59

Merged
merged 19 commits into from
Oct 25, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Aug 28, 2022

Fix #60

Create an end-to-end example for how to create extension for adding lab-specific metadata to an NWBFile by extending the LabMetaData type

TODO:

@oruebel oruebel changed the title Add extension and best practices draft Add end-to-end extension example for extending LabMetaData Sep 23, 2022
@oruebel oruebel marked this pull request as ready for review September 23, 2022 23:52
@oruebel
Copy link
Contributor Author

oruebel commented Sep 23, 2022

@bendichter @rly I've made the changes we discussed. This PR is ready for review.


git add spec/*.yaml
git commit -m "Added extension schema files"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add all the files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean do git add spec/ instead? Since the spec folder should only contain YAML files, both approaches should typically be identical. Either way is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean add the Python files, i.e. git add . instead. This could be a separate step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's fine too. The main reason for this was because those are the files that I modified in this step, so I just tried to be specific about that, but either way is fine.

@rly
Copy link
Contributor

rly commented Oct 25, 2022

I moved the bullet point about git add . to right before pip install . Looks good to me!

@oruebel oruebel merged commit fb7d269 into main Oct 25, 2022
@oruebel oruebel deleted the ext/bestpractices branch October 25, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extension example for LabMetaData
2 participants