Add Events and LabeledEvents types #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
requested changes
Sep 13, 2019
core/nwb.event.yaml
Outdated
| could contain 101 values, where label_map[0] is 'No reward', label_map[10] is '10% reward', | ||
| label_map[100] is 'Full reward', and all other entries in 'label_map' are the empty string. | ||
| datasets: | ||
| - name: labels |
There was a problem hiding this comment.
How would you feel about making this dataset optional? If it is not supplied, the label keys are 0, 1, 2, ... Another option would be to keep this as is and build that into the API.
There was a problem hiding this comment.
Might be a good use of DynamicTable. Users could then add additional metadata to their labels.
Co-Authored-By: Ben Dichter <ben.dichter@gmail.com>
Co-Authored-By: Ben Dichter <ben.dichter@gmail.com>
Co-Authored-By: Ben Dichter <ben.dichter@gmail.com>
Co-Authored-By: Ben Dichter <ben.dichter@gmail.com>
bendichter
previously approved these changes
Oct 1, 2019
bendichter
previously approved these changes
Oct 9, 2019
|
I am putting together an extension here that would benefit from having |
bendichter
reviewed
Feb 19, 2020
Open
|
The proposed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301