Skip to content

Commit

Permalink
Add default name="units" to Units object in the mock_Units test…
Browse files Browse the repository at this point in the history
…ing function (#1883)
  • Loading branch information
h-mayorquin committed Apr 24, 2024
1 parent 2259bed commit 001a9fd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
- Support `stimulus_template` as optional predefined column in `IntracellularStimuliTable`. @stephprince [#1815](https://github.com/NeurodataWithoutBorders/pynwb/pull/1815)
- Support `NWBDataInterface` and `DynamicTable` in `NWBFile.stimulus`. @rly [#1842](https://github.com/NeurodataWithoutBorders/pynwb/pull/1842)
- Added support for python 3.12 and upgraded dependency versions. This also includes infrastructure updates for developers. @mavaylon1 [#1853](https://github.com/NeurodataWithoutBorders/pynwb/pull/1853)
- Added `mock_Units` for generating Units tables. @h-mayorquin [#1875](https://github.com/NeurodataWithoutBorders/pynwb/pull/1875)
- Added `mock_Units` for generating Units tables. @h-mayorquin [#1875](https://github.com/NeurodataWithoutBorders/pynwb/pull/1875) and [#1883](https://github.com/NeurodataWithoutBorders/pynwb/pull/1883)

### Bug fixes
- Fix bug with reading file with linked `TimeSeriesReferenceVectorData` @rly [#1865](https://github.com/NeurodataWithoutBorders/pynwb/pull/1865)
Expand Down
2 changes: 1 addition & 1 deletion src/pynwb/testing/mock/ecephys.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def mock_Units(
nwbfile: Optional[NWBFile] = None,
) -> Units:

units_table = Units()
units_table = Units(name="units") # This is for nwbfile.units= mock_Units() to work
units_table.add_column(name="unit_name", description="a readable identifier for the unit")

rng = np.random.default_rng(seed=seed)
Expand Down

0 comments on commit 001a9fd

Please sign in to comment.