Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test tutorials across python versions #1659

Closed
bendichter opened this issue Mar 9, 2023 · 1 comment
Closed

test tutorials across python versions #1659

bendichter opened this issue Mar 9, 2023 · 1 comment
Assignees
@mavaylon1
Labels
priority: medium non-critical problem and/or affecting only a small set of NWB users topic: docs issues related to documentation topic: testing issues related to testing
Milestone
2.7.0

Comments

@bendichter
Copy link
Contributor

We are currently limiting the test matrix of the tutorials due to the AllenSDK.

pynwb/.github/workflows/run_all_tests.yml

Lines 92 to 107 in cc5fd34

- { name: linux-gallery-python3.7-minimum , test-tox-env: gallery-py37-minimum , python-ver: "3.7" , os: ubuntu-latest }
- { name: linux-gallery-python3.8-upgraded , test-tox-env: gallery-py38-upgraded , python-ver: "3.8" , os: ubuntu-latest }
- { name: linux-gallery-python3.8-prerelease , test-tox-env: gallery-py38-prerelease , python-ver: "3.8" , os: ubuntu-latest }
# allensdk is not compatible with python 3.9+, so run gallery tests only on python <=3.8
# - { name: linux-gallery-python3.10-upgraded , test-tox-env: gallery-py310-upgraded , python-ver: "3.10", os: ubuntu-latest }
# - { name: linux-gallery-python3.10-prerelease , test-tox-env: gallery-py310-prerelease, python-ver: "3.10", os: ubuntu-latest }
- { name: windows-gallery-python3.7-minimum , test-tox-env: gallery-py37-minimum , python-ver: "3.7" , os: windows-latest }
- { name: windows-gallery-python3.8-upgraded , test-tox-env: gallery-py38-upgraded , python-ver: "3.8" , os: windows-latest }
- { name: windows-gallery-python3.8-prerelease , test-tox-env: gallery-py38-prerelease , python-ver: "3.8" , os: windows-latest }
# - { name: windows-gallery-python3.10-upgraded , test-tox-env: gallery-py310-upgraded , python-ver: "3.10", os: windows-latest }
# - { name: windows-gallery-python3.10-prerelease, test-tox-env: gallery-py310-prerelease, python-ver: "3.10", os: windows-latest }
- { name: macos-gallery-python3.7-minimum , test-tox-env: gallery-py37-minimum , python-ver: "3.7" , os: macos-latest }
- { name: macos-gallery-python3.8-upgraded , test-tox-env: gallery-py38-upgraded , python-ver: "3.8" , os: macos-latest }
- { name: macos-gallery-python3.8-prerelease , test-tox-env: gallery-py38-prerelease , python-ver: "3.8" , os: macos-latest }
# - { name: macos-gallery-python3.10-upgraded , test-tox-env: gallery-py310-upgraded , python-ver: "3.10", os: macos-latest }
# - { name: macos-gallery-python3.10-prerelease , test-tox-env: gallery-py310-prerelease, python-ver: "3.10", os: macos-latest }

The latest AllenSKD claims to support Python 3.9: https://github.com/AllenInstitute/AllenSDK/blob/1caa779b517eeb2428282919d0fb8a65e7217791/setup.py#L92

And anyway I don't think at this point we should be limiting our entire testing suite based on the Allen SDK.
@oruebel oruebel added the priority: medium non-critical problem and/or affecting only a small set of NWB users label Mar 9, 2023
@oruebel oruebel added this to the Next Release milestone Mar 9, 2023
@oruebel oruebel added topic: docs issues related to documentation topic: testing issues related to testing labels Mar 9, 2023
@rly rly mentioned this issue Mar 24, 2023
Open
3 tasks
@rly
Copy link
Contributor

rly commented Mar 24, 2023

I created a new issue for this in #1679

@rly rly closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavaylon1 mavaylon1

Labels
priority: medium non-critical problem and/or affecting only a small set of NWB users topic: docs issues related to documentation topic: testing issues related to testing
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
4 participants
@rly @bendichter @oruebel @mavaylon1